chore: add Storybook workflow doc #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcramer
reviewed
Jul 16, 2024
| ```bash | ||
| yarn storybook:dev | ||
|
|
||
| # In a browser, navigate to http://localhost:6006/ |
There was a problem hiding this comment.
We can leave this out since yarn storybook:dev auto directs the user to that url
cpcramer
reviewed
Jul 16, 2024
| @@ -65,6 +65,18 @@ onchainkit | |||
|
|
|||
| ## Workflows | |||
|
|
|||
| ### Storybook | |||
There was a problem hiding this comment.
I think that this section needs more step by step guidance - I'm new to Storybook, and this section in its current state does not help me understand how contributing to onchainKit / Storybook works.
Zizzamia
approved these changes
Aug 26, 2024
|
@siddharthkul, I approved and merge for now, but @cpcramer is right, we need a bit more love into this section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added docs for storybook workflow
How has it been tested?
cd site && yarn dev